Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] add deployment environment resource #528

Closed
raboley opened this issue Aug 12, 2020 · 6 comments
Closed

[feature request] add deployment environment resource #528

raboley opened this issue Aug 12, 2020 · 6 comments
Labels
Good first issue Good for newcomers New resource Type: Feature New feature or request

Comments

@raboley
Copy link

raboley commented Aug 12, 2020

I like the idea of using github environments, and for my repositories that are only terraform it would be nice to have this be part of the github provider.

I would think this could be a resource that always ran last and could succeed for the environment if all terraform succeeded, and fail if it failed.

The reason I thought of terraform is for transient environments that when I delete them I would want to inactivate the environment that the transient branch belonged to. Any feedback on this idea would be appreciated!

thanks!

@raboley raboley closed this as completed Aug 12, 2020
@raboley
Copy link
Author

raboley commented Aug 12, 2020

oops wrong issue

@jcudit
Copy link
Contributor

jcudit commented Nov 26, 2020

This is a cool concept, thanks for starting the discussion! 🤔 what what example HCL look like?

@srgustafson8
Copy link
Contributor

I just had a PR merged into the go-github module that provides the client for environments and environment secrets (google/go-github#1847). Not sure how long this will take to make it's way here but it may help

@threeseed
Copy link
Contributor

For those interested I am currently working on this in conjunction wth #681.

@threeseed
Copy link
Contributor

PR has been raised. Huge thank you to @srgustafson8 for adding support in go-github.

@kfcampbell
Copy link
Member

Closing as #805 has been merged. Thanks @nadenf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers New resource Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants