-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v3.0.0 Breaking Changes To Provider Schema #521
Conversation
Breaking changes to provider configuration: - Token becomes optional - Organization no longer deprecated - `individual` and `anonymous` removed - `owner` inferred from `organization` This also refactors the provider configuration testing into a new `provider_utils` file alongside the original test file. The aim was to make this suite of tests more readable.
- Add tests - Add `Meta()` instead of `Clients()`
Removes a couple of statements that are no longer in use that were tripping up the linter.
Added more testing around the GHES use case. This is functioning well locally and will push to merge this week. Follow up PRs are expected as iteration continues towards the new acceptance testing workflow. |
Experimentation with `ConflictsWith` for this use case added too much friction. This diff opts to use a custom `OwnerOrOrgEnvDefaultFunc` function instead to ensure owner and organization flags are used correctly in CI.
https://github.com/terraform-providers/terraform-provider-github/pull/544 addresses the concerns raised above. I will merge this to accommodate progress on refreshing most tests and adding new testing workflows. |
Is it possible that there is an undocumented breaking change here? When upgrading from 2.9 to 3.1 I had to change from provider "github" {
base_url = "https://my-ghe-host/api/v3"
organization = "my-org"
} to provider "github" {
base_url = "https://my-ghe-host"
organization = "my-org"
} |
Ahead of our next major release, this PR modifies the provider schema in the following ways:
token
becomes optional, with its absence signallinganonymous
modeorganization
is no longer deprecated and instead enables the management of organization-only resourcesindividual
andanonymous
removedowner
inferred fromorganization
when presentThis also refactors the provider configuration testing into a new
provider_utils
file alongside the original test file. The aim was to make this suite of tests more readable.Finally, a trivial
github_organization
data source was added to aid in testing./cc https://github.com/terraform-providers/terraform-provider-github/issues/502#issuecomment-652399602