-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade provider to go-github v31.0.0 to support new API methods #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
size/XXL
label
Apr 10, 2020
Only Acceptance test failure I see atm is for the ssh key referenced (seems expected):
|
# Conflicts: # github/data_source_github_team.go # github/resource_github_team_membership.go # github/resource_github_team_membership_test.go # go.mod # vendor/modules.txt
Additional test failures relating to missing
|
Merged
Acceptance tests, after merge with master, are passing w/the following known exceptions (including https://github.com/terraform-providers/terraform-provider-github/issues/431):
|
anGie44
added a commit
that referenced
this pull request
May 5, 2020
anGie44
added a commit
that referenced
this pull request
Jul 31, 2020
jcudit
pushed a commit
that referenced
this pull request
Jul 31, 2020
jcudit
pushed a commit
that referenced
this pull request
Sep 2, 2020
jcudit
pushed a commit
that referenced
this pull request
Sep 4, 2020
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…thub_upgrade_v31 upgrade provider to go-github v31.0.0 to support new API methods
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release of
go-github
will enable provider support of IdP groups for teams ; data and resource to be added in #400Changes include:
go-github
references modified from v29 -> v31#GetTeamMembership
->#GetTeamMembershipByID
#ListTeamMembers
->#ListTeamMembersByID