Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_repository documentation incorrect argument for delete_branch_on_merge #419

Closed
deppy opened this issue Apr 7, 2020 · 1 comment · Fixed by #408
Closed

github_repository documentation incorrect argument for delete_branch_on_merge #419

deppy opened this issue Apr 7, 2020 · 1 comment · Fixed by #408

Comments

@deppy
Copy link

deppy commented Apr 7, 2020

The documentation provides an argument called auto_delete_head_branch but the code calls it delete_branch_on_merge.

You can verify that auto_delete_head_branch is incorrect with:

resource "github_repository" "example" {
  name                                   = "example"
  description                         = "My awesome codebase"
  delete_branch_on_merge = true
}

and then simply run terraform validate

@anGie44
Copy link
Contributor

anGie44 commented Apr 9, 2020

hi @deppy! Just wanted to follow-up and note I'm going to close this as a recent merge of #408 addresses what you've pointed out. Thanks for the work you put into creating the issue/PR though :)

@anGie44 anGie44 closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants