resource/github_repository: Introduce option to manage Delete Branch on Merge
#399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since [this commit](google/go-github#1388) it is possible to manage if the project should close branches automatically after a PR is merged. The current version on this project already supports this new config. This commit introduces the new option, using the same default as the GitHub API uses. Fix https://github.com/terraform-providers/terraform-provider-github/issues/264
ghost
added
the
bltavares
changed the title
Delete Branch on MergeDelete Branch on Merge
|
@jcudit Sorry, I hadn't seen https://github.com/terraform-providers/terraform-provider-github/pull/265 previously, and it seems also outdated. Should I close this PR and let the other land instead? |
|
any update on this? |
jcudit
approved these changes
Apr 2, 2020
|
Oh, awesome! I thought they didn't have API support for it. Can't wait to try it, thank you! |
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…erge resource/github_repository: Introduce option to manage `Delete Branch on Merge`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this commit it
is possible to manage if the project should close branches automatically
after a PR is merged.
The current version on this project already supports this new config.
This commit introduces the new option, using the same default as the
GitHub API uses.
Fix #264
Closes #265
Better reviewed with
?w=1on the url to hide whitespace introduced by gofmt