Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/github_branch_protection: Support enforce_admins, update branch protection #26

Merged
merged 2 commits into from
Jul 5, 2017

Conversation

grubernaut
Copy link
Contributor

@grubernaut grubernaut commented Jun 29, 2017

  • Updates branch_protection resource for the new pull_request_reviews.
  • Adds enforce_admins
  • Fixes crash on empty items
  • Updates and fixes tests
$ make testacc TEST=./github TESTARGS="-run=TestAccGithubBranchProtection_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./github -v -run=TestAccGithubBranchProtection_ -timeout 120m
=== RUN   TestAccGithubBranchProtection_basic
--- PASS: TestAccGithubBranchProtection_basic (6.32s)
=== RUN   TestAccGithubBranchProtection_emptyItems
--- PASS: TestAccGithubBranchProtection_emptyItems (4.21s)
=== RUN   TestAccGithubBranchProtection_importBasic
--- PASS: TestAccGithubBranchProtection_importBasic (3.77s)
PASS
ok      github.com/terraform-providers/terraform-provider-github/github 14.307s

Fixes: #18 #8

@grubernaut grubernaut added crash Type: Feature New feature or request labels Jun 29, 2017
…tection

- Updates `branch_protection` resource for the new pull_request_reviews.
- Adds `enforce_admins`
- Fixes crash on empty items
- Updates and fixes tests

```
$ make testacc TEST=./github TESTARGS="-run=TestAccGithubBranchProtection_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./github -v -run=TestAccGithubBranchProtection_ -timeout 120m
=== RUN   TestAccGithubBranchProtection_basic
--- PASS: TestAccGithubBranchProtection_basic (6.32s)
=== RUN   TestAccGithubBranchProtection_emptyItems
--- PASS: TestAccGithubBranchProtection_emptyItems (4.21s)
=== RUN   TestAccGithubBranchProtection_importBasic
--- PASS: TestAccGithubBranchProtection_importBasic (3.77s)
PASS
ok      github.com/terraform-providers/terraform-provider-github/github 14.307s
```
@grubernaut grubernaut changed the title r/github_branch_protection: Support enforce_admins, update branch pro… r/github_branch_protection: Support enforce_admins, update branch protection Jun 29, 2017
Copy link

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any valid configurations right now, that upon merging this and upgrading, will receive a diff in future plans, due to the list->set changes?

Copy link

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grubernaut grubernaut merged commit 87c5cd9 into master Jul 5, 2017
@grubernaut grubernaut deleted the b-migrate-enforce-admins branch July 5, 2017 15:59
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
…-enforce-admins

r/github_branch_protection: Support enforce_admins, update branch protection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support enforce_admins API schema in Github Branch Protection
2 participants