Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT]: Update version of go-github #2358

Closed
1 task done
grahamhar opened this issue Aug 21, 2024 · 2 comments · Fixed by #2359
Closed
1 task done

[MAINT]: Update version of go-github #2358

grahamhar opened this issue Aug 21, 2024 · 2 comments · Fixed by #2359
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@grahamhar
Copy link
Contributor

grahamhar commented Aug 21, 2024 •
edited
Loading

Describe the need

New features have been added to go-github and released in V65, I will raise a PR to implement this.

SDK Version

go-github v65

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@grahamhar grahamhar added Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Aug 21, 2024
@grahamhar grahamhar mentioned this issue Aug 21, 2024
Merged
4 tasks
@kfcampbell kfcampbell moved this from 🆕 Triage to 🏗 In progress in 🧰 Octokit Active Aug 26, 2024
@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Aug 26, 2024
@zepeng811
Copy link
Contributor

zepeng811 commented Sep 16, 2024 •
edited
Loading

@grahamhar v65 was just released and I want to upgrade it to unblock a feature we've been waiting for a long time.

I don't want to step over the work you've already done, do you mind updating your existing PR to v65 instead? #2359

I confirmed that there should be no breaking changes from v64 -> v65 for this repository

@zepeng811 zepeng811 mentioned this issue Sep 16, 2024
Open
1 task
@grahamhar
Copy link
Contributor Author

grahamhar commented Sep 16, 2024 •
edited
Loading

@grahamhar v65 was just released and I want to upgrade it to unblock a feature we've been waiting for a long time.

I don't want to step over the work you've already done, do you mind updating your existing PR to v65 instead? #2359

I confirmed that there should be no breaking changes from v64 -> v65 for this repository

@zepeng811 I have just quickly done that, not had a chance to run tests but a go build ran cleanly.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🧰 Octokit Active Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update go-github to V65 grahamhar/terraform-provider-github
3 participants
@grahamhar @kfcampbell @zepeng811