Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Ruleset bypass actors create unnecessary terraform diffs #2088

Open
1 task done
quoimec opened this issue Jan 9, 2024 · 2 comments
Open
1 task done

[BUG]: Ruleset bypass actors create unnecessary terraform diffs #2088

quoimec opened this issue Jan 9, 2024 · 2 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@quoimec
Copy link

quoimec commented Jan 9, 2024

Expected Behavior

I have not made any change to the bypass actors in my org ruleset so when I apply a terraform change, it should not produce a diff relating to the bypass actors.

Actual Behavior

Terraform finds a diff between the state and remote, where it wants to flip the order of the bypass actors in the state.

Example:
image

After I have applied this change, if I attempt to re-apply no diff will be found. However, if I come back and re-apply in a day for example, the diff will be there again.

I see this diff all the time - I'm just trying to understand what is going on because it causes our systems to run terraform applies when there is no need.

Terraform Version

Terraform v1.6.3

Affected Resource(s)

  • github_repository_ruleset
  • github_organization_ruleset

Terraform Configuration Files

No response

Steps to Reproduce

No response

Debug Output

No response

Panic Output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@quoimec quoimec added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jan 9, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Jan 9, 2024
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Jan 18, 2024
@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Jan 18, 2024
@jgutschon
Copy link

Adding on to this, I'm also seeing this (currently on v5.43.0) but I was able to work around it by reordering the bypass_actors blocks in the terraform code to match the plan. Looking at the plans I think it's trying to order each block so either the actor_id or actor_type is ascending.

@usmonster
Copy link
Contributor

Reminds me of #1952, which was only partially fixed by #1950.
Any clues, next steps, or suggestions for a full resolution, @o-sama?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

4 participants