Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Add packages IP ranges to github_ip_ranges #1812

Closed
1 task done
mikkoc opened this issue Jul 26, 2023 · 2 comments · Fixed by #1958
Closed
1 task done

[FEAT]: Add packages IP ranges to github_ip_ranges #1812

mikkoc opened this issue Jul 26, 2023 · 2 comments · Fixed by #1958
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@mikkoc
Copy link

mikkoc commented Jul 26, 2023

Describe the need

https://api.github.com/meta has packages IP ranges.

These are not yet available in the data source github_ip_ranges

Can you please add them?

SDK Version

5.32.0

API Version

5.32.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mikkoc mikkoc added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Jul 26, 2023
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Jul 26, 2023
@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Jul 26, 2023
@nickfloyd nickfloyd added the hacktoberfest Issues for participation in Hacktoberfest label Sep 21, 2023
@Pati93
Copy link

Pati93 commented Oct 14, 2023

Hi all,
I would like to work on this issue.

@Nmishin Nmishin mentioned this issue Oct 14, 2023
Merged
4 tasks
@kfcampbell
Copy link
Member

@Pati93 in the future, please feel free to open up PRs for any issue you like! In this case, it looks like #1958 is already open for this issue and we're simply waiting on a google/go-github release.

@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for packages IP ranges in github_ip_ranges Nmishin/terraform-provider-github
4 participants
@nickfloyd @mikkoc @kfcampbell @Pati93