Remove deprecated bottle :unneeded call (#1)
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update kubeval.rb * Update conftest.rb Remove `bottle :unneeded` as it is no longer supported per HomeBrew CLI message: ``` Warning: Calling bottle :unneeded is deprecated! There is no replacement. Please report this issue to the instrumenta/instrumenta tap (not Homebrew/brew or Homebrew/core): /usr/local/Homebrew/Library/Taps/instrumenta/homebrew-instrumenta/Formula/kubeval.rb:6 ```
|
LGTM. Hopefully, @garethr, you can review and merge this at your convenience. 🙏 |
|
@garethr just checking if you saw the mention above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2
Remove
bottle :unneededas it is no longer supported per HomeBrew CLI message:I realize these files aren't supposed to be edited directly, but this could be an intermediate fix if it's easier that doing a new release.