-
Notifications
You must be signed in to change notification settings - Fork 274
(Fixed by #57) Demo page render PDF incorrectly #56
Comments
Just tried to build pdf.js version 1.4.162 (df7afcf004c407cc9488a5120425b62d22aaecd4) and it can render that pdf correctly. |
Sorry forgot to update back to here. It turns out to be re-entrance problem when trying to render the PDF page by the scrollbar event. For example, the scrollbar event would trigger N events thus the same PDF page will be rendered N times simultaneously. I found this from #45, then https://github.com/DynamicEnvironmentSystems/pdf-annotate.js/pull/7/commits/3e05fdec53e93e689d25eeed0acb54d7a979f98b. Although the fix should be applied to main.js instead of web/index.js. I've tried to fix the re-entrance problem in my local main.js and it works. When I continue my project, I will submit the fix to my fork. But I wonder where should I submit the pull request to because I'm not sure is this project still being maintained? |
Fixes by #57 |
@AP-Nothize @zwily @zwily |
The demo site http://instructure.github.io/pdf-annotate.js/ rendered the PDF incorrectly as shown in the screen capture. It is expected to show the same content as https://mozilla.github.io/pdf.js/web/viewer.html .
Why is that?
Is it possible to upgrade pdf.js to the latest version?
The text was updated successfully, but these errors were encountered: