Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resources): fix nil response handling #151

Merged
merged 1 commit into from
May 9, 2024
Merged

fix(resources): fix nil response handling #151

merged 1 commit into from
May 9, 2024

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented May 9, 2024

Because

  • In the case of error response, will cause resource methods to fail

This commit

  • return none if request failed

@heiruwu heiruwu force-pushed the fix-none-response branch 3 times, most recently from f164462 to f5b3249 Compare May 9, 2024 08:57
@heiruwu heiruwu force-pushed the fix-none-response branch from f5b3249 to 9cdcf40 Compare May 9, 2024 09:01
@heiruwu heiruwu merged commit c6df35c into main May 9, 2024
7 checks passed
@heiruwu heiruwu deleted the fix-none-response branch May 9, 2024 09:03
@droplet-bot droplet-bot mentioned this pull request May 9, 2024
Merged
heiruwu pushed a commit that referenced this pull request Jun 6, 2024
@droplet-bot
chore(main): release 0.10.0 (#146)
b1f9870 
🤖 I have created a release *beep* *boop*
---


##
[0.10.0](v0.9.0...v0.10.0)
(2024-06-05)


### Features

* **client, resources:** adopt latest api spec
([#145](#145))
([bafa292](bafa292))
* **dockerfile:** separate config and weights into different layers
([#156](#156))
([8d25fc3](8d25fc3))
* **ray:** support cuda version and fix user root permission
([#158](#158))
([cd1fa69](cd1fa69))


### Bug Fixes

* **clients:** fix message length
([#147](#147))
([8083761](8083761))
* **resources:** fix nil response handling
([#151](#151))
([c6df35c](c6df35c))


### Documentation

* **readme:** update workflow name
([ba36a91](ba36a91))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiruwu @droplet-bot