Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only change the related milestone for issue/PR events #8

Open
marissamarym opened this issue May 8, 2020 · 1 comment
Open

Only change the related milestone for issue/PR events #8

marissamarym opened this issue May 8, 2020 · 1 comment
Labels
optimization
Milestone
✌️ v2

Comments

@marissamarym
Copy link
Contributor

Right now, if the action is triggered on issue/PR events, it'll get the entire list of milestones and check all of them. It's more efficient to only get the related milestone (the one that was added or removed), and process only that one.

This optimization will mostly help in the case of bulk operations, where multiple instances of the action will be running in parallel.
@marissamarym marissamarym changed the title Expose a setting for only changing the related milestone on issue/PR events Only change the related milestone for issue/PR events May 8, 2020
@marissamarym marissamarym added this to the ✌️ v2 milestone May 8, 2020
@marissamarym
Copy link
Contributor Author

It's possible to check what the event was from within the action, so doesn't need to be a setting ⚡️

@ethedev ethedev mentioned this issue May 14, 2020
Closed
@ethedev ethedev mentioned this issue Jun 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization
Projects
None yet
Milestone
✌️ v2
Development

No branches or pull requests
1 participant
@marissamarym