-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Remove nested tf.function #391
Comments
Already fixed in #362. |
Having |
Thanks @jcformanek! Can you please make an issue for this with the above advice that we look at fixing it for other systems as well. |
Reopening this issue until we fix the problem in all other systems. |
#353 handles this for ppo. |
Closing all TF issues as we are depreciating our TF systems. |
Describe the bug
Nested
tf.function
decorators are causes TF to constantly retrace which is could cause significant performance and memory issues.Additional context
I think this bug creeped in when we refactored our code to separate forward and backward passes.
Possible Solution
Remove
tf.function
decorator from the backward pass.This bug is also related to #77 and #346
The text was updated successfully, but these errors were encountered: