Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove Update Batch Size #1132

Open
1 task
RuanJohn opened this issue Nov 9, 2024 · 0 comments
Open
1 task

[FEATURE] Remove Update Batch Size #1132

RuanJohn opened this issue Nov 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@RuanJohn
Copy link
Collaborator

RuanJohn commented Nov 9, 2024

Please describe the purpose of the feature. Is it related to a problem?

This is somewhere between a feature and maintenance. Having to vmap an extra time is not necessarily as good an idea as we thought when we started rewriting Mava in JAX. I think it would be better to rather be able to use twice as many environments and then only have an outer pmap. It'll also remove a non-standard config option.

Describe the solution you'd like

Remove the update_batch_size config option and update all systems accordingly.

How do we know when implementation of this feature is complete?

Checklist:

  • All systems are benchmarked and can get similar performance.
@RuanJohn RuanJohn added the enhancement New feature or request label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant