Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Insert events into preloaded logs #1407

Closed
Henning-Schulz opened this issue Apr 27, 2022 · 0 comments
Closed

[Feature] - Insert events into preloaded logs #1407

Henning-Schulz opened this issue Apr 27, 2022 · 0 comments
Assignees
Labels
area/agent enhancement New feature or request

Comments

@Henning-Schulz
Copy link
Member

Is your feature request related to a problem? Please describe.
The new agent command to retrieve logs is nice, but I would like to know better when some relevant events happened when viewing the logs. For example, when a new instrumentation config was fetched, old instrumentation logs get outdated. However, the default log-preloading config only considers WARN and ERROR logs, which don't contain the INFO messages about newly applied instrumentation.

Describe the solution you'd like
I would like the agent to put artificial log entries into the preloaded logs that mark certain events (such as instrumentation) occur.

Describe alternatives you've considered
An alternative would be to throw away instrumentation logs whenever new instrumentations are applied, which is however very complex to realize. Also, we don't really benefit from throwing away the logs and there might be edge cases where the "outdated" logs are still interesting.

Additional context
As we plan to connect the log retrieval with a health status indicator, the artificial log entries will also help understanding the current health, as it is based on the same logs and events.

@Henning-Schulz Henning-Schulz added the idea A rough idea for a feature or extension label Apr 27, 2022
@Henning-Schulz Henning-Schulz self-assigned this Apr 27, 2022
@mariusoe mariusoe added enhancement New feature or request area/agent and removed idea A rough idea for a feature or extension labels May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants