Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Conversion of old boolean values to new ExporterEnabledState does not work when in quotes #1356

Closed
aaronweissler opened this issue Mar 22, 2022 · 0 comments
Assignees
Labels

Comments

@aaronweissler
Copy link
Member

Describe the bug
When the boolean for the enabled property is written in quotes, it is treated as a String by Spring and therefore can not be converted using the BooleanToExporterEnabledStateConverter

To Reproduce
Steps to reproduce the behavior:

  1. Set an enabled property to "false"
  2. Start any core test that loads properties
  3. See error in logs

Expected behavior
Convert the value to equivalent ExporterEnabledState

Additional information (screenshots, stack traces, etc.)
Caused by: org.springframework.core.convert.ConversionFailedException: Failed to convert from type [java.lang.String] to type [rocks.inspectit.ocelot.config.model.exporters.ExporterEnabledState] for value 'false'; nested exception is java.lang.IllegalArgumentException: No enum constant rocks.inspectit.ocelot.config.model.exporters.ExporterEnabledState.false

@aaronweissler aaronweissler added the bug Something isn't working label Mar 22, 2022
@aaronweissler aaronweissler self-assigned this Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant