Skip to content
This repository has been archived by the owner on Nov 21, 2017. It is now read-only.

Optimizing use of the cache #4

Open
Satyam opened this issue Jul 12, 2014 · 1 comment
Open

Optimizing use of the cache #4

Satyam opened this issue Jul 12, 2014 · 1 comment

Comments

@Satyam
Copy link

Satyam commented Jul 12, 2014

Mithirl caches nodes created via the m() function, indexed by its first argument.

This is an example of a node that caches well:

m('a#google.external[href="http://google.com"]", 'Google'); 

If all those attributes, class, id and href were not part of the first argument, only an empty a node would be cached and the rest of the attributes would have to be assembled one by one, every time that the view is called.

MSX should be able to distinguish attributes that are constant:

<div class="panel-heading">

from those that are variable, that is, that get their value from an expression:

<span class={g.disabled()?'text-muted':''}>

The first should result in:

m('div.panel-heading')

The second in:

m('span',{class:g.disabled()?'text-muted':''})

This would greatly speed up the refresh process.

@insin
Copy link
Owner

insin commented Jan 23, 2015

Am I right to assume that the pull request for #1 obviates the need for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants