-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cardano network on aggregator status and explorer #2149
Merged
Alenar
merged 6 commits into
main
from
djo/2144/cardano-network-on-aggregator-status-and-explorer
Nov 29, 2024
Merged
Cardano network on aggregator status and explorer #2149
Alenar
merged 6 commits into
main
from
djo/2144/cardano-network-on-aggregator-status-and-explorer
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding the list of connection options used in the 'open' log message instead of doing a log for each option.
jpraynaud
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
mithril-explorer/src/components/ControlPanel/AggregatorStatus/index.js
Outdated
Show resolved
Hide resolved
dlachaume
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Alenar
temporarily deployed
to
testing-preview
November 28, 2024 17:30
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
November 28, 2024 17:30
— with
GitHub Actions
Inactive
In the 'epoch ###' card, below the eras.
Alenar
force-pushed
the
djo/2144/cardano-network-on-aggregator-status-and-explorer
branch
from
November 28, 2024 18:50
46545f9
to
1fa098a
Compare
As this route is not yet deployed in stable there's no use to add a golden test for this change.
* mithril-persistence from `0.2.38` to `0.2.39` * mithril-aggregator from `0.5.116` to `0.5.117` * mithril-common from `0.4.90` to `0.4.91` * [js] mithril-explorer from `0.7.19` to `0.7.20` * openapi.yaml from `0.1.37` to `0.1.38`
sfauvel
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Alenar
temporarily deployed
to
testing-preview
November 29, 2024 09:47
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
November 29, 2024 09:47
— with
GitHub Actions
Inactive
Alenar
deleted the
djo/2144/cardano-network-on-aggregator-status-and-explorer
branch
November 29, 2024 09:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR add a
cardano_network
key in the data returned by the aggregator/status
route and update the explorer to display it in itsAggregatorStatus
component.Pre-submit checklist
Comments
Not directly related to this PR, the first commit simplify the logs of the connection builder in persistence to limit the numbers of logs to one instead of up to four when opening a connection without applying migrations.
Issue(s)
Closes #2144