Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano network on aggregator status and explorer #2149

Merged

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Nov 28, 2024

Content

This PR add a cardano_network key in the data returned by the aggregator /status route and update the explorer to display it in its AggregatorStatus component.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Comments

Not directly related to this PR, the first commit simplify the logs of the connection builder in persistence to limit the numbers of logs to one instead of up to four when opening a connection without applying migrations.

Issue(s)

Closes #2144

@Alenar Alenar self-assigned this Nov 28, 2024
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

github-actions bot commented Nov 28, 2024

Test Results

    4 files  ±0     51 suites  ±0   11m 34s ⏱️ -18s
1 415 tests +1  1 415 ✅ +1  0 💤 ±0  0 ❌ ±0 
1 626 runs  +1  1 626 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 9e9716c. ± Comparison against base commit 379fbd1.

♻️ This comment has been updated with latest results.

In the 'epoch ###' card, below the eras.
@Alenar Alenar force-pushed the djo/2144/cardano-network-on-aggregator-status-and-explorer branch from 46545f9 to 1fa098a Compare November 28, 2024 18:50
As this route is not yet deployed in stable there's no use to add a
golden test for this change.
* mithril-persistence from `0.2.38` to `0.2.39`
* mithril-aggregator from `0.5.116` to `0.5.117`
* mithril-common from `0.4.90` to `0.4.91`
* [js] mithril-explorer from `0.7.19` to `0.7.20`
* openapi.yaml from `0.1.37` to `0.1.38`
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alenar Alenar merged commit 44004bf into main Nov 29, 2024
50 checks passed
@Alenar Alenar deleted the djo/2144/cardano-network-on-aggregator-status-and-explorer branch November 29, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the Cardano network in the status page
4 participants