Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An ADR to keep rejected ADRs 'forever' #282

Merged
2 commits merged into from
Mar 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 23, 2022

No description provided.

@ghost ghost requested review from ch1bo and KtorZ March 23, 2022 07:31
@github-actions
Copy link

github-actions bot commented Mar 23, 2022

Unit Test Results

    5 files  ±0    71 suites  ±0   9m 3s ⏱️ + 1m 57s
191 tests ±0  189 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 9e0d3cf. ± Comparison against base commit e82a162.

♻️ This comment has been updated with latest results.

@ch1bo
Copy link
Member

ch1bo commented Mar 23, 2022

Sounds good! We should also merge ADRs in Draft state very easily, i.e. it should have all relevant sections filled. Discussion and acceptance/rejection can then be done in second PR if needed. From my side this is one could be even be merged as Accepted right away (if we have full approval on this).

@ghost ghost force-pushed the abailly-iohk/keep-rejected-adrs-adr.md branch from 64e5652 to 9e0d3cf Compare March 28, 2022 08:34
@ghost ghost merged commit 342de6e into master Mar 28, 2022
@ghost ghost deleted the abailly-iohk/keep-rejected-adrs-adr.md branch March 28, 2022 11:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants