Make subscription valency dependent on number of peers #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a hardcoded value for the valency of Ouroboros subscriptions, which meant the network engine would stop connecting to peers once it reached the target valency, thus preventing us from scaling to more than 7 peers.
ghost
requested review from
KtorZ
approved these changes
Feb 15, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a hardcoded value for the valency of Ouroboros subscriptions, which meant the network engine would stop connecting to peers once it reached the target valency, thus preventing us from scaling to more than 7 peers.
Note the benchmark is still failing with 10 nodes because the
CollectComcannot be posted on-chain because the limit is 9: https://github.com/input-output-hk/hydra-poc/blob/abailly-iohk/fix-ouroboros-scaling/hydra-node/test/Hydra/Chain/Direct/TxSpec.hs#L198