Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

Remove spendingPassword from /api/v1/transactions/fees #271

Open
piotr-iohk opened this issue Jan 29, 2019 · 0 comments
Open

Remove spendingPassword from /api/v1/transactions/fees #271

piotr-iohk opened this issue Jan 29, 2019 · 0 comments
Labels
ACCEPTED ADR has been accepted

Comments

@piotr-iohk
Copy link
Contributor

piotr-iohk commented Jan 29, 2019

Context

The API doc dor POST /api/v1/transactions/fees reads -> this endpoint does not require a spending password to be supplied..., however it is listed there as an optional parameter. (cf https://input-output-hk.github.io/cardano-wallet/#tag/Transactions%2Fpaths%2F~1api~1v1~1transactions~1fees%2Fpost. )

Currently this parameter is not required at all for estimating fee so it can be removed from this endpoint (including API doc)

Decision

Remove spendingPassword from the POST /api/v1/transactions/fees and update API doc accordingly.

Acceptance Criterias

  1. The API must have spendingPassword removed from POST /api/v1/transactions/fees
  2. Api doc must be updated accordingly
  3. Client.getTransactionFee needs to be updated as well not to use the spendingPassword (?)

Development Plan

PR

Number Base
#? develop

QA

Criteria Coverage
? -

Retrospective

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ACCEPTED ADR has been accepted
Projects
None yet
Development

No branches or pull requests

3 participants