-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Introduced breaking changes in Pluto as we are intro… #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ducing credential abstraction and anoncred issuing functionality. - X25519 keys were wrongly set as EC (elliptic) key types which is wrong. EC25519 + Secp256k1 belong to EC key type, X25519 should have Curve25519 instead to be valid. If you previously had a key stored as EC (x25519) changing that keyType to KeyTypes.X25519 (Curve25519). - As we have introduced new credential types we have also built a credential abstraction so storing and fetching credentials becomes easier.
elribonazo
changed the title
BREAKING CHANGE: Introduced breaking changes in Pluto as we are intro…
docs: Introduced breaking changes in Pluto as we are intro…
Nov 7, 2023
curtis-h
approved these changes
Nov 7, 2023
atala-dev
added a commit
that referenced
this pull request
Nov 7, 2023
# [3.0.0](v2.5.0...v3.0.0) (2023-11-07) * docs!: Introduced breaking changes in Pluto as we are intro… (#116) ([be8c6e8](be8c6e8)), closes [#116](#116) ### Features * **Agent:** add initialize function ([#107](#107)) ([14389a1](14389a1)) ### BREAKING CHANGES * Introduced breaking changes in Pluto as we are introducing credential abstraction and anoncred issuing functionality. - X25519 keys were wrongly set as EC (elliptic) key types which is wrong. EC25519 + Secp256k1 belong to EC key type, X25519 should have Curve25519 instead to be valid. If you previously had a key stored as EC (x25519) changing that keyType to KeyTypes.X25519 (Curve25519). - As we have introduced new credential types we have also built a credential abstraction so storing and fetching credentials becomes easier.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
# [3.0.0](v2.5.0...v3.0.0) (2023-11-07) * docs!: Introduced breaking changes in Pluto as we are intro… (#116) ([be8c6e8](be8c6e8)), closes [#116](#116) ### Features * **Agent:** add initialize function ([#107](#107)) ([14389a1](14389a1)) ### BREAKING CHANGES * Introduced breaking changes in Pluto as we are introducing credential abstraction and anoncred issuing functionality. - X25519 keys were wrongly set as EC (elliptic) key types which is wrong. EC25519 + Secp256k1 belong to EC key type, X25519 should have Curve25519 instead to be valid. If you previously had a key stored as EC (x25519) changing that keyType to KeyTypes.X25519 (Curve25519). - As we have introduced new credential types we have also built a credential abstraction so storing and fetching credentials becomes easier.
mixmix
pushed a commit
to mixmix/atala-prism-wallet-sdk-ts
that referenced
this pull request
May 6, 2024
…dger#116) BREAKING CHANGE: Introduced breaking changes in Pluto as we are introducing credential abstraction and anoncred issuing functionality. - X25519 keys were wrongly set as EC (elliptic) key types which is wrong. EC25519 + Secp256k1 belong to EC key type, X25519 should have Curve25519 instead to be valid. If you previously had a key stored as EC (x25519) changing that keyType to KeyTypes.X25519 (Curve25519). - As we have introduced new credential types we have also built a credential abstraction so storing and fetching credentials becomes easier. Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
mixmix
pushed a commit
to mixmix/atala-prism-wallet-sdk-ts
that referenced
this pull request
May 6, 2024
# [3.0.0](hyperledger/identus-edge-agent-sdk-ts@v2.5.0...v3.0.0) (2023-11-07) * docs!: Introduced breaking changes in Pluto as we are intro… (hyperledger#116) ([be8c6e8](hyperledger@be8c6e8)), closes [hyperledger#116](hyperledger#116) ### Features * **Agent:** add initialize function ([hyperledger#107](hyperledger#107)) ([14389a1](hyperledger@14389a1)) ### BREAKING CHANGES * Introduced breaking changes in Pluto as we are introducing credential abstraction and anoncred issuing functionality. - X25519 keys were wrongly set as EC (elliptic) key types which is wrong. EC25519 + Secp256k1 belong to EC key type, X25519 should have Curve25519 instead to be valid. If you previously had a key stored as EC (x25519) changing that keyType to KeyTypes.X25519 (Curve25519). - As we have introduced new credential types we have also built a credential abstraction so storing and fetching credentials becomes easier. Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are about to release prism 2.6 and as reported by a user we have missed introducing the breaking change in Pluto. Despite Pluto is not part of our bundle anymore, we do cause disruption with existing users and the correct is to apply the breaking change.
Only positive thing is that 2.5.0 is part of 2.6 prism release which is not yet released, its a draft release.
This PR does not introduce the breaking change but just applies the configuration and doc changes.