Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prism-agent): add syncwave to certificate to fix race condition with tls #686

Merged

Conversation

milosbackonja
Copy link
Contributor

@milosbackonja milosbackonja commented Sep 5, 2023

Overview

Fixes ATL-xxxx

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Atala PRISM Test Results

  69 files  ±0    69 suites  ±0   8m 34s ⏱️ -28s
544 tests ±0  533 ✔️ ±0  11 💤 ±0  0 ±0 
548 runs  ±0  537 ✔️ ±0  11 💤 ±0  0 ±0 

Results for commit 77313c0. ± Comparison against base commit 7fdffe3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

E2E Test Results

10 files  ±0  10 suites  ±0   5m 44s ⏱️ -11s
21 tests ±0  21 ✔️ ±0  0 💤 ±0  0 ±0 
32 runs  ±0  32 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 77313c0. ± Comparison against base commit 7fdffe3.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@antonbaliasnikov antonbaliasnikov changed the title feat(agent): add syncwave to certificate to fix race condition with tls feat(prism-agent): add syncwave to certificate to fix race condition with tls Sep 5, 2023
@milosbackonja milosbackonja merged commit 854dcf9 into main Sep 6, 2023
@milosbackonja milosbackonja deleted the feature/ATL-5394-tls-object-creation-race-condition branch September 6, 2023 08:36
atala-dev added a commit that referenced this pull request Sep 6, 2023
# [1.14.0](prism-agent-v1.13.0...prism-agent-v1.14.0) (2023-09-06)

### Bug Fixes

* change private sdk 1.4 to public maven ([#685](#685)) ([128bcac](128bcac))
* **prism-agent:** update invitation expiration on connection request ([#687](#687)) ([1a1702f](1a1702f))

### Features

* **prism-agent:** add syncwave to certificate to fix race condition with tls ([#686](#686)) ([854dcf9](854dcf9))

Signed-off-by: Anton Baliasnikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants