Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prism-agent): metrics for issuance flow #669

Merged
merged 8 commits into from
Sep 5, 2023
Merged

feat(prism-agent): metrics for issuance flow #669

merged 8 commits into from
Sep 5, 2023

Conversation

shotexa
Copy link
Contributor

@shotexa shotexa commented Aug 30, 2023 •
edited
Loading

Overview

Fixes ATL-5551

  • issuance_flow_holder_req_pending_to_generated_ms_gauge
    • the number of milliseconds it takes for a record to move from pending to generated state on the Holder side
  • issuance_flow_holder_req_generated_to_sent_ms_gauge
    • the number of milliseconds it takes for a record to move from generated to sent state on the Holder side
  • issuance_flow_issuer_credential_pending_to_generated_ms_gauge
    • the number of milliseconds it takes for a record to move from pending to sent generated on the Issuer side
  • issuance_flow_issuer_credential_generated_to_sent_ms_gauge
    • the number of milliseconds it takes for a record to move from generated to sent state on the Issuer side
  • issuance_flow_issuer_offer_pending_to_sent_ms_gauge
    • the number of milliseconds it takes for a record to move from pending to sent on the Issuer side
  • issuance_flow_holder_req_generated_to_sent_ms_gauge
    • the number of milliseconds it takes for a record to move from generated to sent on the Holder side
  • issuance_flow_issuer_send_offer_msg_failed_counter
    • the number of times the issuer failed to send a message with an Offer
  • issuance_flow_issuer_send_offer_msg_succeed_counter
    • the number of times the issuer succeeded at sending a message with an Offer
  • issuance_flow_issuer_send_offer_flow_succeed_counter
    • the number of times the flow (background job) of the issuer sending an offer has succeeded
  • issuance_flow_issuer_send_offer_flow_failed_counter
    • the number of times the flow (background job) of the issuer sending an offer has failed
  • issuance_flow_issuer_send_offer_flow_all_counter
    • the number of times the flow (background job) of the issuer sending an offer has run (including successful and failed attempts
  • issuance_flow_holder_req_pending_to_generated_flow_success_counter
    • the number of times the flow (background job) of the holder converting a request from pending to generated succeeded
  • issuance_flow_holder_req_pending_to_generated_flow_failed_counter
    • the number of times the flow (background job) of the holder converting a request from pending to generated has failed
  • issuance_flow_holder_req_pending_to_generated_flow_all_counter
    • the number of times the flow (background job) of the holder converting a request from pending to generated nas run (including successful and failed attempts)
  • issuance_flow_holder_send_req_msg_succeed_counter
    • the number of times the holder succeeded at sending a message with a request
  • issuance_flow_holder_send_req_msg_failed_counter
    • the number of times the holder failed to send a message with a request
  • issuance_flow_holder_req_generated_to_sent_flow_success_counter
    • the number of times the flow (background job) of the holder converting a request from generated to sent succeeded
  • issuance_flow_holder_req_generated_to_sent_flow_failed_counter
    • the number of times the flow (background job) of the holder converting a request from generated to sent has failed
  • issuance_flow_holder_req_generated_to_sent_flow_all_counter
    • the number of times the flow (background job) of the holder converting a request from generated to sent has run (including successful and failed attempts)
  • issuance_flow_issuer_cred_received_to_pending_flow_success_counter
    • the number of times the flow (background job) of the issuer converting a credential from received to pending succeeded
  • issuance_flow_issuer_cred_received_to_pending_flow_failed_counter
    • the number of times the flow (background job) of the issuer converting a credential from received to pending failed
  • issuance_flow_issuer_cred_received_to_pending_flow_all_counter
    • the number of times the flow (background job) of the issuer converting a credential from received to pending ran in total
  • issuance_flow_issuer_cred_pending_to_generated_flow_success_counter
    • the number of times the flow (background job) of the issuer converting a credential from pending to generated succeeded
  • issuance_flow_issuer_cred_pending_to_generated_flow_failed_counter
    • the number of times the flow (background job) of the issuer converting a credential from pending to generated failed
  • issuance_flow_issuer_cred_pending_to_generated_flow_all_counter
    • the number of times the flow (background job) of the issuer converting a credential from pending to generated ran in total
  • issuance_flow_issuer_send_cred_success_counter
    • the number of times the flow (background job) of the issuer converting a credential from generated to sent succeeded
  • issuance_flow_issuer_send_cred_failed_counter
    • the number of times the flow (background job) of the issuer converting a credential from generated to sent failed
  • issuance_flow_issuer_send_cred_all_counter
    • the number of times the flow (background job) of the issuer converting a credential from generated to sent ran in total
  • issuance_flow_issuer_send_credential_msg_failed_counter
    • the number of times an issuer has failed to send a credential message to the holder
  • issuance_flow_issuer_send_credential_msg_succeed_counter
    • the number of times an issuer has succeeded at sending a credential message to the holder
  • issuance_flow_issuer_send_offer_ms_gauge
    • the number of milliseconds it takes for an issuer to send an offer to a holder
  • issuance_flow_issuer_send_offer_flow_ms_gauge
    • the number of milliseconds it takes for the issuer to send an offer to holder flow to complete
  • issuance_flow_holder_req_pending_to_generated_flow_ms_gauge
    • the number of milliseconds it takes for the holder to send a request to the issuer flow to complete
  • issuance_flow_holder_send_request_ms_gauge
    • the number of milliseconds it takes for the holder to send a request message to the issuer
  • issuance_flow_holder_req_generated_to_sent_flow_ms_gauge
    • the number of milliseconds it takes for the flow (background job) of the holder to convert a request from generated to sent to complete
  • issuance_flow_issuer_cred_pending_to_generated_flow_ms_gauge
    • the number of milliseconds it takes for the flow (background job) of the issuer to convert a credential from pending to generated to complete
  • issuance_flow_issuer_cred_received_to_pending_flow_ms_gauge
    • the number of milliseconds it takes for the flow (background job) of the issuer to convert a credential from received to pending to complete
  • issuance_flow_issuer_send_credential_msg_ms_gauge
    • the number of milliseconds it takes for the issuer to send a credential message to the holder
  • issuance_flow_issuer_send_cred_flow_ms_gauge
    • the number of milliseconds it takes for the flow (background job) of the issuer to convert a credential from generated to sent to complete

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

Shota Jolbordi added 4 commits August 30, 2023 15:30
Holder pending to generated flow
7c5f4d0 
Signed-off-by: Shota Jolbordi <[email protected]>
holderGeneratedToSentFlow
783e8f0 
Signed-off-by: Shota Jolbordi <[email protected]>
issuerReceivedToPendingFlow
2fcaff7 
Signed-off-by: Shota Jolbordi <[email protected]>
Add metrics to send credential flow
b580fde 
Signed-off-by: Shota Jolbordi <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023 •
edited
Loading

Atala PRISM Test Results

  69 files  ±0    69 suites  ±0   9m 2s ⏱️ ±0s
544 tests ±0  533 ✔️ ±0  11 💤 ±0  0 ❌ ±0 
548 runs  ±0  537 ✔️ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 62d75af. ± Comparison against base commit 7fdffe3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023 •
edited
Loading

E2E Test Results

10 files  ±0  10 suites  ±0   5m 49s ⏱️ -6s
21 tests ±0  21 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
32 runs  ±0  32 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 62d75af. ± Comparison against base commit 7fdffe3.

♻️ This comment has been updated with latest results.

Shota Jolbordi added 2 commits September 5, 2023 19:52
Remove leftower logs
37e7dc9 
Signed-off-by: Shota Jolbordi <[email protected]>
Remove more logs
4241f7f 
Signed-off-by: Shota Jolbordi <[email protected]>
@atala-dev atala-dev removed the castor label Sep 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shotexa shotexa merged commit 20315ae into main Sep 5, 2023
@shotexa shotexa deleted the ATL-5551-metrics-for-issuance-flow branch September 5, 2023 16:17
atala-dev added a commit that referenced this pull request Sep 6, 2023
@atala-dev
chore(release): cut atala prism 1.13.0 release
11fbf92 
# [1.13.0](prism-agent-v1.12.0...prism-agent-v1.13.0) (2023-09-06)

### Bug Fixes

* another indentation in apisixroute ([#683](#683)) ([d7c5e52](d7c5e52))
* correct vault path ([#678](#678)) ([9426e7f](9426e7f))
* CredentialOffer not following spec ([#569](#569)) ([3d479b9](3d479b9))
* indentation in apisixroute ([#682](#682)) ([6eec8ba](6eec8ba))
* **prism-agent:** fix added the InvitationGenerated state to the conn… ([#684](#684)) ([7fdffe3](7fdffe3))
* **prism-agent:** make resolve did representation content type work ([#679](#679)) ([fd417d9](fd417d9))

### Features

* **prism-agent:** metrics for issuance flow ([#669](#669)) ([20315ae](20315ae))

Signed-off-by: Anton Baliasnikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@patlo-iog patlo-iog Awaiting requested review from patlo-iog

@FabioPinheiro FabioPinheiro Awaiting requested review from FabioPinheiro

@mineme0110 mineme0110 Awaiting requested review from mineme0110

@bvoiturier bvoiturier Awaiting requested review from bvoiturier

@CryptoKnightIOG CryptoKnightIOG Awaiting requested review from CryptoKnightIOG

Assignees
No one assigned
Labels
Component: Cloud Agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shotexa @yshyn-iohk @atala-dev