Skip to content

Commit

Permalink
feat(prism-node): add context to protobuf definition (#487)
Browse files Browse the repository at this point in the history
* fix(prism-node): make scalapb not generate default values

* feat(prism-node): add context to prism-node grpc

* ci: update protolint config

* fix(prism-node): fix enum prefix

* ci: update protolint config

* fix(prism-agent): fix protobuf enum suffix

* ci: update linting doc

* feat(prism-node): add PatchContextAction to protobuf

* fix(prism-node): preserve protobuf field name as in spec
  • Loading branch information
patlo-iog authored Mar 29, 2023
1 parent f18b4a8 commit e426a82
Show file tree
Hide file tree
Showing 5 changed files with 181 additions and 150 deletions.
3 changes: 3 additions & 0 deletions .protolintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ lint:
# disable some specific rules
remove:
- REPEATED_FIELD_NAMES_PLURALIZED
- ENUM_FIELD_NAMES_PREFIX
- ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH
- FIELD_NAMES_LOWER_SNAKE_CASE
9 changes: 7 additions & 2 deletions docs/guides/linting.md
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,13 @@ Linter - Suggested Change: Customise

*Change detail*

Add `.protolintrc.yml` used by `protolint` linter and configure it to disable `REPEATED_FIELD_NAMES_PLURALIZED` rule.
This rule should be disabled since it tries to pluralize the field name that doesn't conform to the spec submitted to W3C.
Add `.protolintrc.yml` used by `protolint` linter and configure it to disable the following rules
- `REPEATED_FIELD_NAMES_PLURALIZED`
- `ENUM_FIELD_NAMES_PREFIX`
- `ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH`
- `FIELD_NAMES_LOWER_SNAKE_CASE`

These rules should be disabled since they try to rename some fields deviating from the spec submitted to W3C.

---

Expand Down
Loading

0 comments on commit e426a82

Please sign in to comment.