feat(prism-agent): Add filter by thid to OpenAPI when fetching records (

#436) Mitigation for ATL-3409
hyperledger · Mar 13, 2023 · af01359 · af01359
1 parent 4122615
commit af01359
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 5 deletions.
diff --git a/prism-agent/service/api/http/prism-agent-openapi-spec.yaml b/prism-agent/service/api/http/prism-agent-openapi-spec.yaml
@@ -503,6 +503,12 @@ paths:
       parameters:
         - $ref: "./shared/parameters.yaml#/components/parameters/offset"
         - $ref: "./shared/parameters.yaml#/components/parameters/limit"
+        - name: thid
+          in: query
+          description: The thid of a DIDComm communication.
+          required: false
+          schema:
+            type: string
       responses:
         "200":
           description: The list of issue credential records.
@@ -621,6 +627,12 @@ paths:
       parameters:
         - $ref: "./shared/parameters.yaml#/components/parameters/offset"
         - $ref: "./shared/parameters.yaml#/components/parameters/limit"
+        - name: thid
+          in: query
+          description: The thid of a DIDComm communication.
+          required: false
+          schema:
+            type: string
       responses:
         "200":
           description: The list of proof presentation records.

diff --git a/...cala/io/iohk/atala/agent/server/http/service/IssueCredentialsProtocolApiServiceImpl.scala b/...cala/io/iohk/atala/agent/server/http/service/IssueCredentialsProtocolApiServiceImpl.scala
@@ -72,14 +72,21 @@ class IssueCredentialsProtocolApiServiceImpl(
     }
   }
 
-  override def getCredentialRecords(offset: Option[Int], limit: Option[Int])(implicit
+  override def getCredentialRecords(
+      offset: Option[Int],
+      limit: Option[Int],
+      thid: Option[String],
+  )(implicit
       toEntityMarshallerIssueCredentialRecordCollection: ToEntityMarshaller[IssueCredentialRecordPage],
       toEntityMarshallerErrorResponse: ToEntityMarshaller[ErrorResponse]
   ): Route = {
     val result = for {
-      outcome <- credentialService
+      records <- credentialService
         .getIssueCredentialRecords()
         .mapError(HttpServiceError.DomainError[CredentialServiceError].apply)
+      outcome = thid match
+        case None        => records
+        case Some(value) => records.filter(_.thid.value == value) // this logic should be moved to the DB
     } yield outcome
 
     onZioSuccess(result.mapBoth(_.toOAS, _.map(_.toOAS)).either) {

diff --git a/...r/src/main/scala/io/iohk/atala/agent/server/http/service/PresentProofApiServiceImpl.scala b/...r/src/main/scala/io/iohk/atala/agent/server/http/service/PresentProofApiServiceImpl.scala
@@ -70,16 +70,22 @@ class PresentProofApiServiceImpl(presentationService: PresentationService, conne
 
   }
 
-  override def getAllPresentation(offset: Option[Int], limit: Option[Int])(implicit
+  override def getAllPresentation(
+      offset: Option[Int],
+      limit: Option[Int],
+      thid: Option[String]
+  )(implicit
       toEntityMarshallerPresentationStatusPage: ToEntityMarshaller[PresentationStatusPage],
       toEntityMarshallerErrorResponse: ToEntityMarshaller[ErrorResponse]
   ): Route = {
-
     val result = for {
       records <- presentationService
         .getPresentationRecords()
         .mapError(HttpServiceError.DomainError[PresentationError].apply)
-    } yield records
+      outcome = thid match
+        case None        => records
+        case Some(value) => records.filter(_.thid.value == value) // this logic should be moved to the DB
+    } yield outcome
 
     onZioSuccess(result.mapBoth(_.toOAS, _.map(_.toOAS)).either) {
       case Left(error) => complete(error.status -> error)