fix: Invalid signature integer: negative on JS platform #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
elribonazo
requested review from
hamada147,
goncalo-frade-iohk,
yshyn-iohk,
curtis-h,
cristianIOHK and
amagyar-iohk
as code owners
elribonazo
requested review from
hamada147
and removed request for
hamada147,
curtis-h,
amagyar-iohk,
yshyn-iohk and
cristianIOHK
Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Code Coverage
|
hamada147
approved these changes
May 9, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 9, 2024
…platform (#158) Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
atala-dev
added a commit
that referenced
this pull request
May 9, 2024
## [1.2.16](v1.2.15...v1.2.16) (2024-05-09) ### Bug Fixes * Invalid signature integer: negative on JS platform ([#158](#158)) ([0b454e0](0b454e0))
|
🎉 This PR is included in version 1.2.16 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
May 9, 2024
## [1.2.16](v1.2.15...v1.2.16) (2024-05-09) ### Bug Fixes * Invalid signature integer: negative on JS platform ([#158](#158)) ([0b454e0](0b454e0))
hamada147
added a commit
that referenced
this pull request
May 20, 2024
Signed-off-by: Francisco Javier Ribó Labrador <[email protected]> Co-authored-by: Ahmed Moussa <[email protected]>
hamada147
pushed a commit
that referenced
this pull request
May 20, 2024
## [1.2.16](v1.2.15...v1.2.16) (2024-05-09) ### Bug Fixes * Invalid signature integer: negative on JS platform ([#158](#158)) ([0b454e0](0b454e0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a fix for JS signatures which result in Invalid signature integer: negative.
Simply added a try catch and now we conditionally run the transcoding function as last resource.
All CommonMain and JSMain tests are working.
we are good to go
Checklist: