Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YT & YTM) - "Open GMSCore" button doesn't support forked GMSCore(s) #2112

Closed
5 tasks done
vippium opened this issue Jun 1, 2024 · 4 comments
Closed
5 tasks done
Labels
Bug report Something isn't working

Comments

@vippium
Copy link

vippium commented Jun 1, 2024

Type

Other

Tools used

rvx-builder

Application

GMSCore forks

Bug description

"Open GMSCore" doesn't support or open any of the forked GMSCore. It only support official from revanced. As we know that revanced GMSCore doesn't support hiding from launcher. Due to which many people like me use the rufusin GMSCore as he only added support for hide from launcher.

So, the option should open forked GMSCore(s) from ReX and rufusin too.

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@vippium vippium added the Bug report Something isn't working label Jun 1, 2024
@vippium
Copy link
Author

vippium commented Jun 2, 2024

The same feature (previously) for Microg works well with all the types of Microg. GMSCore option should also be compatible with every GMSCore.

@YT-Advanced
Copy link

Uhm I can still open my own GMSCore via RVX Settings ._.

@inotia00
Copy link
Owner

inotia00 commented Jun 2, 2024

I tested it a while ago, and it doesn't seem to be an issue with RVX

While implementing the feature to remove icons from the launcher, it appears that a certain class org.microg.gms.ui.SettingsActivity has been removed
(Validated in rufusin/GmsCore, It seems that the fork does not reflect the latest GmsCore changes)

I built the GmsCore fork locally, which does not have the feature to remove the icon from the launcher, and it worked normally

Just ask them to fix this in GmsCore fork

@inotia00 inotia00 closed this as completed Jun 2, 2024
@vippium
Copy link
Author

vippium commented Jun 2, 2024

Umm... That's the reason. Well OK.
Waiting for @rufusin to update it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants