ensure building creation handles errors graciously

[derrabauke]

As an additional fix, we should ensure that building creation handles errors graciously, i.e. if when saving a building, if the addWork request fails or the addBuildingToConstructionProject, then the building should be left in a new state. At the moment we trigger modifyBuilding requests after a failed addBuildingToConstructionProject because the isNew flag isn't rolled back correctly.

Originally posted by @luytena in #741 (comment)

[derrabauke]

@luytena I guess you are referring to this?

ember-ebau-gwr/addon/controllers/building/edit/form.js

Lines 110 to 117 in 352f960

	if (this.buildingWork.isNew) {
	const building = yield this.buildingAPI.create(
	this.model.projectId,
	this.buildingWork,
	);
	EGID = building.EGID;
	} else {
	yield this.buildingAPI.update(this.buildingWork.building);

[luytena]

@luytena I guess you are referring to this?

ember-ebau-gwr/addon/controllers/building/edit/form.js

Lines 110 to 117 in 352f960

	if (this.buildingWork.isNew) {
	const building = yield this.buildingAPI.create(
	this.model.projectId,
	this.buildingWork,
	);
	EGID = building.EGID;
	} else {
	yield this.buildingAPI.update(this.buildingWork.building);

Yes, in the create method in essence any exception that causes it to not go by the line buildingWork.isNew = true;

ember-ebau-gwr/addon/services/building.js

Lines 131 to 137 in 352f960

	await this.constructionProject.removeWorkFromProject(EPROID, work.ARBID);
	buildingWork.ARBID = undefined;
	buildingWork.isNew = true;
	console.error("GWR API: addBuildingToConstructionProject failed");
	throw errors;
	}