diff --git a/README.md b/README.md
index c6dc2e1..99a6136 100644
--- a/README.md
+++ b/README.md
@@ -23,14 +23,14 @@ And then add the artifact `incognia-api-client` **or** `incognia-api-client-shad
com.incognia
incognia-api-client
- 3.2.0
+ 3.3.0
```
```xml
com.incognia
incognia-api-client-shaded
- 3.2.0
+ 3.3.0
```
@@ -47,13 +47,13 @@ repositories {
And then add the dependency
```gradle
dependencies {
- implementation 'com.incognia:incognia-api-client:3.2.0'
+ implementation 'com.incognia:incognia-api-client:3.3.0'
}
```
OR
```gradle
dependencies {
- implementation 'com.incognia:incognia-api-client-shaded:3.2.0'
+ implementation 'com.incognia:incognia-api-client-shaded:3.3.0'
}
```
diff --git a/build.gradle b/build.gradle
index f38af33..f37c0d2 100644
--- a/build.gradle
+++ b/build.gradle
@@ -8,7 +8,7 @@ plugins {
}
group = "com.incognia"
-version = "3.2.0"
+version = "3.3.0"
task createProjectVersionFile {
def projectVersionDir = "$projectDir/src/main/java/com/incognia/api"
diff --git a/src/main/java/com/incognia/api/IncogniaAPI.java b/src/main/java/com/incognia/api/IncogniaAPI.java
index d27db82..50d806b 100644
--- a/src/main/java/com/incognia/api/IncogniaAPI.java
+++ b/src/main/java/com/incognia/api/IncogniaAPI.java
@@ -134,9 +134,6 @@ public static IncogniaAPI instance() {
*/
public SignupAssessment registerSignup(RegisterSignupRequest request) throws IncogniaException {
Asserts.assertNotNull(request, "register signup request");
- Asserts.assertNotEmpty(
- Optional.ofNullable(request.getRequestToken()).orElse(request.getInstallationId()),
- "request token");
Optional
address = Optional.ofNullable(request.getAddress());
PostSignupRequestBody postSignupRequestBody =
PostSignupRequestBody.builder()
@@ -190,9 +187,6 @@ public SignupAssessment registerSignup(RegisterSignupRequest request) throws Inc
public TransactionAssessment registerLogin(RegisterLoginRequest request)
throws IncogniaException {
Asserts.assertNotNull(request, "register login request");
- Asserts.assertNotEmpty(
- Optional.ofNullable(request.getRequestToken()).orElse(request.getInstallationId()),
- "request token");
Asserts.assertNotEmpty(request.getAccountId(), "account id");
PostTransactionRequestBody requestBody =
PostTransactionRequestBody.builder()
@@ -388,9 +382,6 @@ public SignupAssessment registerWebSignup(RegisterWebSignupRequest request)
public TransactionAssessment registerPayment(RegisterPaymentRequest request)
throws IncogniaException {
Asserts.assertNotNull(request, "register payment request");
- Asserts.assertNotEmpty(
- Optional.ofNullable(request.getRequestToken()).orElse(request.getInstallationId()),
- "request token");
Asserts.assertNotEmpty(request.getAccountId(), "account id");
List transactionAddresses =
addressMapToTransactionAddresses(request.getAddresses());
diff --git a/src/test/java/com/incognia/api/IncogniaAPITest.java b/src/test/java/com/incognia/api/IncogniaAPITest.java
index 8db5c57..5f11867 100644
--- a/src/test/java/com/incognia/api/IncogniaAPITest.java
+++ b/src/test/java/com/incognia/api/IncogniaAPITest.java
@@ -270,34 +270,6 @@ void testRegisterWebSignup_whenDataIsValid() {
assertThat(webSignupAssessment.getReasons()).containsExactly(expectedReason);
}
- @Test
- @DisplayName("should throw illegal argument exception with correct message")
- @SneakyThrows
- void testRegisterSignup_whenEmptyRequestToken() {
- assertThatThrownBy(
- () ->
- client.registerSignup(
- RegisterSignupRequest.builder()
- .requestToken("")
- .address(AddressFixture.ADDRESS_ADDRESS_LINE)
- .customProperties(null)
- .build()))
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessage("'request token' cannot be empty");
- }
-
- @Test
- @DisplayName("should throw illegal argument exception with correct message")
- @SneakyThrows
- void testRegisterWebSignup_whenEmptyRequestToken() {
- assertThatThrownBy(
- () ->
- client.registerWebSignup(
- RegisterWebSignupRequest.builder().requestToken("").build()))
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessage("'request token' cannot be empty");
- }
-
@ParameterizedTest
@ValueSource(booleans = {true})
@NullSource
@@ -608,54 +580,6 @@ void testRegisterFeedback_whenDataIsValid(boolean dryRun) {
dryRun);
}
- @Test
- @DisplayName("should throw illegal argument exception with correct message")
- @SneakyThrows
- void testRegisterPayment_whenRequestTokenIsNotValid() {
- assertThatThrownBy(
- () ->
- client.registerPayment(
- RegisterPaymentRequest.builder()
- .requestToken("")
- .accountId("account id")
- .build()))
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessage("'request token' cannot be empty");
- assertThatThrownBy(
- () ->
- client.registerPayment(
- RegisterPaymentRequest.builder()
- .requestToken(null)
- .accountId("account id")
- .build()))
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessage("'request token' cannot be empty");
- }
-
- @Test
- @DisplayName("should throw illegal argument exception with correct message")
- @SneakyThrows
- void testRegisterLogin_whenRequestTokenIsNotValid() {
- assertThatThrownBy(
- () ->
- client.registerLogin(
- RegisterLoginRequest.builder()
- .requestToken("")
- .accountId("account id")
- .build()))
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessage("'request token' cannot be empty");
- assertThatThrownBy(
- () ->
- client.registerLogin(
- RegisterLoginRequest.builder()
- .requestToken(null)
- .accountId("account id")
- .build()))
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessage("'request token' cannot be empty");
- }
-
@Test
@DisplayName("should throw illegal argument exception with correct message")
@SneakyThrows