Fix dyld lock not getting unlocked on invalid threads. (JuliaLang#49446)

inkydragon · Apr 29, 2023 · b4d1530 · b4d1530
1 parent faced27
commit b4d1530
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/signals-mach.c b/src/signals-mach.c
@@ -614,12 +614,12 @@ void *mach_profile_listener(void *arg)
             if (_dyld_atfork_prepare != NULL && _dyld_atfork_parent != NULL)
                 _dyld_atfork_prepare(); // briefly acquire the dlsym lock
             host_thread_state_t state;
-            if (!jl_thread_suspend_and_get_state2(i, &state))
-                continue;
+            int valid_thread = jl_thread_suspend_and_get_state2(i, &state);
             unw_context_t *uc = (unw_context_t*)&state;
             if (_dyld_atfork_prepare != NULL && _dyld_atfork_parent != NULL)
                 _dyld_atfork_parent(); // quickly release the dlsym lock
-
+            if (!valid_thread)
+                continue;
             if (running) {
 #ifdef LLVMLIBUNWIND
                 /*