Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use uint64 for chain IDs and heights in structs, events, etc #64

Open
prestwich opened this issue Jul 17, 2024 · 2 comments · May be fixed by #69
Open

use uint64 for chain IDs and heights in structs, events, etc #64

prestwich opened this issue Jul 17, 2024 · 2 comments · May be fixed by #69

Comments

@prestwich
Copy link
Contributor

prestwich commented Jul 17, 2024 •
edited
Loading

change block height and chain ids to be uint64 instead of uint32 or uint256

for consistency with other toolchains :)
@prestwich prestwich changed the title use uint64 for chain IDs in structs, events, etc use uint64 for chain IDs and heights in structs, events, etc Jul 17, 2024
@prestwich
Copy link
Contributor Author

also related to init4tech/zenith-rs#34

@PraneshASP
Copy link

I'd like to take this on!

@PraneshASP PraneshASP linked a pull request Jul 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update chainid and block numbers type to uint64 PraneshASP/zenith
2 participants
@prestwich @PraneshASP