Skip to content

Commit

Permalink
Merge pull request kubernetes#101 from enxebre/mhc-diagram
Browse files Browse the repository at this point in the history
Add machine health check diagram
  • Loading branch information
openshift-merge-robot authored Nov 7, 2019
2 parents 5b3bc10 + 1ec0792 commit 260aacf
Show file tree
Hide file tree
Showing 4 changed files with 54 additions and 0 deletions.
2 changes: 2 additions & 0 deletions enhancements/machine-api/machine-health-checking.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ Out of band:
- The machine controller provider deletes the instance.
- The machine controller deletes the machine.

![Machine health check](./mhc.svg)

#### Out of tree remediation controller, e.g baremetal reboot:
- An external remediation can plug in by setting the `healthchecking.openshift.io/strategy: reboot` on the MHC resource.
- An external remediation controller remediation could then watch machines annotated with `healthchecking.openshift.io/remediation: reboot` and react as it sees fit.
Expand Down
20 changes: 20 additions & 0 deletions enhancements/machine-api/mhc.plantuml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
@startuml
start;
:Machine Health Check controller;
repeat
repeat
:Watch MHCs;
:Find unhealthy targets: Need remediation or going towards timeout;
repeat while (unhealthyTargets > maxUnhealthy) is (yes)
-> no;
repeat while (API server machine deletion requests for machines that need remediation) is (requeue with minTime to timeout delay)

-[#blue,dashed]-> Out of band;
#LightBlue:The machine owner controller watches deletion timestamp.
Reconciles towards desired number of replicas.
The process to create a new machine/node starts;
#LightBlue:The machine controller drains the unhealthy node;
#LightBlue:The machine controller provider deletes the unhealthy instance;
#LightBlue:The machine controller removes the unhealthy machine finalizer;
#LightBlue:The API server removes the unhealthy machine resource;
@enduml
Binary file added enhancements/machine-api/mhc.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
32 changes: 32 additions & 0 deletions enhancements/machine-api/mhc.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 260aacf

Please sign in to comment.