implement iam-runtime GetAccessToken #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemrm
force-pushed
the
implement-exchange-token
branch
from
44ec769 to
3c057e2
Compare
mikemrm
force-pushed
the
implement-exchange-token
branch
from
3c057e2 to
6684a7d
Compare
mikemrm
changed the title
mikemrm
force-pushed
the
implement-exchange-token
branch
2 times, most recently
from
2c38384 to
f681ba6
Compare
mikemrm
force-pushed
the
implement-exchange-token
branch
2 times, most recently
from
37b4cd3 to
db28be4
Compare
mikemrm
force-pushed
the
implement-exchange-token
branch
from
db28be4 to
85889cf
Compare
mikemrm
force-pushed
the
implement-exchange-token
branch
2 times, most recently
from
1f18247 to
73ce84e
Compare
This implements the GetAccessToken method which returns an access token upon request. Returned tokens can be configured to be from a file or client credentials. Additionally the sourced token can be exchanged for another token. This is particularly useful within a kubernetes cluster. You can exchange the service account token for one from another issuer. Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
implement-exchange-token
branch
from
73ce84e to
c5ef94c
Compare
jnschaeffer
reviewed
May 3, 2024
Comment on lines
+89
to
+91
| oauth2.SetAuthURLParam("grant_type", s.cfg.GrantType), | ||
| oauth2.SetAuthURLParam("subject_token", s.upstreamToken.AccessToken), | ||
| oauth2.SetAuthURLParam("subject_token_type", s.cfg.TokenType), |
There was a problem hiding this comment.
Usually I like to make OAuth parameters constants elsewhere, though in this case since we're not reusing them anywhere this might be fine.
Co-authored-by: John Schaeffer <[email protected]> Signed-off-by: Mike Mason <[email protected]>
Co-authored-by: John Schaeffer <[email protected]> Signed-off-by: Mike Mason <[email protected]>
Signed-off-by: Mike Mason <[email protected]>
Signed-off-by: Mike Mason <[email protected]>
Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
implement-exchange-token
branch
from
f769099 to
593cd3a
Compare
jnschaeffer
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the GetAccessToken method which returns an access token upon request.
Returned tokens can be configured to be from a file or client credentials.
Additionally the sourced token can be exchanged for another token.
This is particularly useful within a kubernetes cluster.
You can exchange the service account token for one from another issuer.