-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tendermint config #897
update tendermint config #897
Conversation
Codecov Report
@@ Coverage Diff @@
## master #897 +/- ##
========================================
- Coverage 69.8% 69.7% -0.1%
========================================
Files 200 200
Lines 16320 16311 -9
========================================
- Hits 11393 11380 -13
- Misses 4927 4931 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks very much! 🎉 🙏 Just one minor request regarding the changelog.
CHANGELOG.md
Outdated
@@ -4,6 +4,7 @@ | |||
|
|||
- `[tendermint-abci,tendermint-rpc]` Fix DeliverTx response deserialization | |||
issues with `gas_wanted` and `gas_used` fields ([#876]) | |||
- `[tendermint]` Update TendermintConfig for Tendermint v.0.34.x ([#896]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this entry as a separate file in the .changelog/unreleased/bug-fixes
folder.
See https://github.com/informalsystems/tendermint-rs/blob/master/CONTRIBUTING.md#changelog for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you too,unclog
looks very handy for this!
Just a note, the format shown in CONTRIBUTING shows - [pkg] \#xxx Some description about the change
, but the other entries in .changelog
had a slightly different format, so I followed that for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll update that in the contributing guidelines 👍
This reverts commit 5141329.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much! 🙏
closes #896
Hello, I'm trying to use the config module with Tendermint v0.34.x and I found that lots of the options have been changed. I've updated them to be in line with https://github.com/tendermint/tendermint/blob/v0.34.10/config/toml.go.
.changelog/