Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rpc-probe a first-class testing tool #756

Closed
greg-szabo opened this issue Dec 20, 2020 · 0 comments · Fixed by #758
Closed

Make rpc-probe a first-class testing tool #756

greg-szabo opened this issue Dec 20, 2020 · 0 comments · Fixed by #758

Comments

@greg-szabo
Copy link
Member

greg-szabo commented Dec 20, 2020

Enhances #723 .

  • Move rpc-probe under tools/rpc-probe.
  • Make it create its files under rpc/tests/kvstore-fixtures.
  • Create an rpc-tests/kvstore.rs test file that reads all fixtures and JSON deserializes them.
  • Make the binary emit a version.json file that has the Tendermint version it ran against.
  • Possibly make rpc-probe set up docker with the kvstore endpoint (a la the kvstore-test crate using cargo-make).
  • Fix all the folder traversals / -> PathBuf::join for correct cross-platform exexcution.

(Possibly in a new issue: repeat steps 2-5 and create a gaiad-fixtures using the gaiad endpoint.)

Note: I've crossed off the version control file. The reason: rpc-probe doesn't know exactly what endpoint it's running against. The docker image is defined in cargo-make. We'll have to rely on that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant