-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tendermint/0.33 / #196 followup issue #211
Comments
|
This would become obsolete if we switched to using an jsonrpc library instead. Otherwise the tests I had in mind would look similar to: https://github.com/paritytech/jsonrpc/blob/ef92a481d76802da489f0f57dfdf4d459d7f7f76/core/src/types/id.rs#L16 |
All comments addressed as far as I can see. |
Collecting all outstanding discussions for full 0.33 compatibility and review comments from #196 and #199 and related issues here:
@ancazamfir re-tested this and it
This was likely resolved as part of the serialization refactoring @greg-szabo did.
The text was updated successfully, but these errors were encountered: