You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like the (current) implementation of ibc uses amino and in the current rust implementation (ibc_rs) needs to be able decode these. It would be good if the concrete types that already live in tendermint-rs would have their prost / prost_amino annotated counterparts live in the tendermint-rs repo too instead of adding them to the ibc-rs repo.
I'll add a amino_types.rs module to ibc-rs to unblock this: informalsystems/hermes#45 but as soon as this works we should move them into tendermint-rs and update the dependency on tendermint in ibc-rs.
Looks like the (current) implementation of ibc uses amino and in the current rust implementation (ibc_rs) needs to be able decode these. It would be good if the concrete types that already live in tendermint-rs would have their prost / prost_amino annotated counterparts live in the tendermint-rs repo too instead of adding them to the ibc-rs repo.
I'll add a amino_types.rs module to ibc-rs to unblock this: informalsystems/hermes#45 but as soon as this works we should move them into tendermint-rs and update the dependency on tendermint in ibc-rs.
Example types that should also allow serialization via amino or prost / protobuf are the
SignedHeader
,ValidatorSet
. They are implicitly contained in thelatest_header
field here:https://github.com/informalsystems/ibc-rs/blob/b603ccc6a0ddeaa37caf3d78dded3374d4a7056d/modules/src/ics07_tendermint/client_state.rs#L11-L17
ref: #197
The text was updated successfully, but these errors were encountered: