You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ancazamfir uncovered what we think is a discrepancy between the way ABCI Merkle proofs are represented in this crate vs the Go implementation.
The AbciQuery datatype into which ABCI responses are deserialized* carries an optional Proof, which is defined in this crate as a wrapper around a bytevector serialized as a hex-encoded string, whereas the corresponding struct in the Go code is defined as an actual struct with proof ops etc.
It is thus currently not possible to properly deserialize the result of ABCI queries when those carry a proof, as shown in the tests Anca included in her PR implementing a consensus state query for ibc-rs.
* We should perhaps find a better name for that struct, since it is used both for queries and their responses. Or perhaps the issue stems from the fact that those should be different datatypes?
The text was updated successfully, but these errors were encountered:
@ancazamfir uncovered what we think is a discrepancy between the way ABCI Merkle proofs are represented in this crate vs the Go implementation.
The
AbciQuery
datatype into which ABCI responses are deserialized* carries an optionalProof
, which is defined in this crate as a wrapper around a bytevector serialized as a hex-encoded string, whereas the corresponding struct in the Go code is defined as an actual struct with proof ops etc.It is thus currently not possible to properly deserialize the result of ABCI queries when those carry a proof, as shown in the tests Anca included in her PR implementing a consensus state query for
ibc-rs
.* We should perhaps find a better name for that struct, since it is used both for queries and their responses. Or perhaps the issue stems from the fact that those should be different datatypes?
The text was updated successfully, but these errors were encountered: