Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block: domain type validation is too stringent #1435

Closed
erwanor opened this issue Jun 4, 2024 · 1 comment · Fixed by #1436
Closed

block: domain type validation is too stringent #1435

erwanor opened this issue Jun 4, 2024 · 1 comment · Fixed by #1436
Assignees
Labels
bug Something isn't working

Comments

@erwanor
Copy link
Collaborator

erwanor commented Jun 4, 2024

What went wrong?

Comet allows non-zero initial heights, those are useful and should be considered frequent (e.g. Penumbra use them to perform offchain state transitions).

However, the domain type validation logic of Block enforces an initialHeight of 1 which is too stringent:

https://github.com/informalsystems/tendermint-rs/blame/94a5fc074964fca05df48acde88ce133a58f4ce7/tendermint/src/block.rs#L125

Definition of "done"

The check is dropped so that it is possible to parse blocks that don't refer to a last commit. Open to better suggestions but that seem straightforward to do.

@erwanor erwanor added the bug Something isn't working label Jun 4, 2024
@romac
Copy link
Member

romac commented Jun 4, 2024

Agreed, the domain types are indeed too restrictive in multiple places as we've seen recently. Feel free to open a PR to relax that specific restriction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants