-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tendermint-proto: grpc server definitions for rpc/abci #1338
Conversation
Co-authored-by: Tomas Tauber <[email protected]> Co-authored-by: Tony Arcieri <[email protected]>
Co-authored-by: Tomas Tauber <[email protected]> Co-authored-by: Tony Arcieri <[email protected]>
Co-authored-by: Tomas Tauber <[email protected]> Co-authored-by: Tony Arcieri <[email protected]>
Co-authored-by: Tomas Tauber <[email protected]> Co-authored-by: Tony Arcieri <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1338 +/- ##
=======================================
+ Coverage 59.3% 59.5% +0.2%
=======================================
Files 273 272 -1
Lines 27095 26973 -122
=======================================
Hits 16068 16068
+ Misses 11027 10905 -122
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for the review @mzabaluev, I have bumped to However, I was not able to run the proto compiler as I previously did, so the PR has the old definitions:
|
@erwanor This looks like a weird problem with the local git repository checkout. Try removing There may be changes in the code generated by tonic-build 0.9, so I'd like to be sure the output is checked in. |
They are still generated, but I have slapped the |
Thanks for your help with this, I owe you one! |
Partially addresses #1225. This PR adds gRPC server definitions for the rpc and abci services, but not (yet) for the privval service since it is blocked on #9256 for now. I have added @tony-iqlusion and @tomtau as coauthors since this PR is duplicating work that was previously included-then-yanked from
0.35
..changelog/