More idiomatic domain types for privval responses #1228
Labels
domain-types
Anything relating to the creation, modification or removal of domain types
enhancement
New feature or request
technical debt
Issues that are important, but not urgent, that should eventually receive attention
Description
The
privval
gRPC protocol responses have the same structure and convention: they either have the usable value field, or the error field present. This looks very much like the RustResult
type, and the tendermint-rs domain type should also be an enum with a conversion toResult
, if not straightResult
(unfortunately, it's not possible to defineProtobuf
conversions for the latter).Definition of "done"
These types in
tendermint
are changed to enums to represent either a success value or aRemoteSignerError
variant:proposal::SignedProposalResponse
public_key::PubKeyResponse
vote::SignedVoteResponse
In
TryFrom
conversions from the tendermint-proto structs, presence of both fields is treated as an error.The text was updated successfully, but these errors were encountered: