Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LightClientAttackEvidence #1219

Closed
mzabaluev opened this issue Oct 27, 2022 · 0 comments · Fixed by #1292
Closed

Support LightClientAttackEvidence #1219

mzabaluev opened this issue Oct 27, 2022 · 0 comments · Fixed by #1292
Assignees
@romac
Labels
enhancement New feature or request ibc Required by IBC rpc

Comments

@mzabaluev
Copy link
Contributor

Description

Properly encode LightClientAttackEvidence variant of Evidence messages with data provided by the client.
Currently the Evidence domain type lacks required data in its LightClientAttackEvidence variant.

Required by informalsystems/hermes#2772

Definition of "done"

  • A LightClientAttackEvidence struct and a Evidence::LightClientAttack variant carrying it is provided in tendermint, with encoding support from/to the protobuf LightClientAttackEvidence message and serde implementations for RPC.
  • The supervisor code in tendermint-light-client is changed to report LightClientAttackEvidence data upon detecting a fork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

Labels
enhancement New feature or request ibc Required by IBC rpc
Projects
None yet
Milestone
No milestone
2 participants
@romac @mzabaluev