Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero address appearing as sender in testnet when minting IBC tokens #276

Closed
Farhad-Shabani opened this issue Feb 11, 2025 · 1 comment · Fixed by #275 or #296
Closed

Zero address appearing as sender in testnet when minting IBC tokens #276

Farhad-Shabani opened this issue Feb 11, 2025 · 1 comment · Fixed by #275 or #296

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Feb 11, 2025

Context

While testing a sample token transfer on testnet, it was observed that the sender address appears as 0x00…0. This occurs because ICS-20 directly mints the token into the recipient’s account, making the sender address zero, instead of showing the actual ICS-20 contract as the sender.

Proposal

We can first mint the tokens to the ICS-20 contract itself and then perform the transfer. This ensures that the ICS-20 address is correctly reflected as the sender.

Remark

(Since token creation happens only once, this approach should not introduce any significant overhead.)
It actually should be observed for the minting (not just token creation) process as well.

@Farhad-Shabani Farhad-Shabani added this to the MVP Demo #2 milestone Feb 11, 2025
@Farhad-Shabani Farhad-Shabani self-assigned this Feb 11, 2025
@Farhad-Shabani Farhad-Shabani changed the title Zero address appearing as sender in testnet when creating new IBC tokens Zero address appearing as sender in testnet when minting IBC tokens Feb 11, 2025
@rnbguy
Copy link
Member

rnbguy commented Feb 14, 2025

This is fixed for mint.

But we forgot to do the same for burn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment