Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module scoping in the libraries #95

Closed
3 of 5 tasks
adizere opened this issue Jan 14, 2021 · 1 comment
Closed
3 of 5 tasks

Module scoping in the libraries #95

adizere opened this issue Jan 14, 2021 · 1 comment
Labels
A: good-first-issue Admin: good for newcomers O: new-feature Objective: aims to add new feature

Comments

@adizere
Copy link
Member

adizere commented Jan 14, 2021

Crate

ibc and relayer

Summary

We should consider exporting modules with more restrictive scoping, e.g., pub(crate) instead of pub.

Original discussion

I actually wanted to ask this before, why don't we use the crate scope more often. I believe in this case for example all mods, except application, can be public at crate level.

Originally posted by @ancazamfir in #518 (comment)

I don't thin it matters too much for the relayer-cli crate, but yeah in general it wouldn't hurt either to make more modules crate scoped, to limit the surface area of our libs.

Originally posted by @romac in #518 (comment)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac
Copy link
Member

romac commented Feb 8, 2022

Let's keep exporting most things publicly until we get a better idea of what is the surface area needed by downstream users of the ibc and ibc-relayer crate.

@romac romac closed this as completed Feb 8, 2022
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: good-first-issue Admin: good for newcomers O: new-feature Objective: aims to add new feature
Projects
None yet
Development

No branches or pull requests

2 participants