Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo doc check to CI #332

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Add cargo doc check to CI #332

merged 1 commit into from
Jan 6, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #330


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 62.96% // Head: 62.96% // No change to project coverage 👍

Coverage data is based on head (03d577b) compared to base (475ffa0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   62.96%   62.96%           
=======================================
  Files         124      124           
  Lines       13931    13931           
=======================================
  Hits         8772     8772           
  Misses       5159     5159           
Impacted Files Coverage Δ
crates/ibc/src/lib.rs 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review January 6, 2023 19:40
@Farhad-Shabani Farhad-Shabani added the S: CI/CD Scope: related to CI/CD label Jan 6, 2023
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@plafer plafer merged commit 9b4c146 into main Jan 6, 2023
@plafer plafer deleted the farhad/330-cargo-doc branch January 6, 2023 20:11
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: CI/CD Scope: related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cargo doc check to CI
2 participants