Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dumping Prometheus metrics to JSON #2890

Closed
5 tasks
romac opened this issue Nov 28, 2022 · 0 comments · Fixed by #2843
Closed
5 tasks

Add support for dumping Prometheus metrics to JSON #2890

romac opened this issue Nov 28, 2022 · 0 comments · Fixed by #2843
Assignees
@romac
Labels
I: telemetry Internal: related to Telemetry & metrics
Milestone
v1.2

Comments

@romac
Copy link
Member

romac commented Nov 28, 2022 •
edited
Loading

Summary

Add a ?format=json flag to the metrics endpoint to dump Prometheus metrics as JSON instead of Prometheus' bespoke text format.

This would make it easier in some cases to work with the metrics, eg. by allowing to use curl + jq to process the metrics.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added this to the v1.2 milestone Nov 28, 2022
@romac romac self-assigned this Nov 28, 2022
@romac romac added I: telemetry Internal: related to Telemetry & metrics A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Nov 28, 2022
@romac romac mentioned this issue Nov 28, 2022
Merged
7 tasks
@adizere adizere added this to Hermes Dec 13, 2022
@adizere adizere moved this to 📋 Backlog in Hermes Dec 13, 2022
@adizere adizere moved this from 📋 Backlog to ✅ Done in Hermes Dec 13, 2022
@seanchen1991 seanchen1991 removed the A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

Labels
I: telemetry Internal: related to Telemetry & metrics
Projects
Hermes
Archived in project
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

Add support for dumping Prometheus metrics to JSON informalsystems/hermes
2 participants
@romac @seanchen1991