Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgTimeoutOnClose verifies wrong proof for closed channel state #1217

Closed
rnbguy opened this issue May 7, 2024 · 0 comments · Fixed by #1215
Closed

MsgTimeoutOnClose verifies wrong proof for closed channel state #1217

rnbguy opened this issue May 7, 2024 · 0 comments · Fixed by #1215
Assignees
@rnbguy
Labels
A: bug Admin: something isn't working A: critical Admin: critical or Important

Comments

@rnbguy
Copy link
Member

rnbguy commented May 7, 2024

Bug Summary

The current logic for MsgTimeoutOnClose uses proof_unreceived_on_b instead of proof_close_on_b during channel state verification.

Details

https://github.com/cosmos/ibc-rs/blob/4ea4dcb863efa12f5628a05588e2207112035e4a/ibc-core/ics04-channel/src/handler/timeout_on_close.rs#L105-L118

Version

till v0.52.0
@rnbguy rnbguy added A: bug Admin: something isn't working A: critical Admin: critical or Important labels May 7, 2024
@rnbguy rnbguy self-assigned this May 7, 2024
@rnbguy rnbguy mentioned this issue May 7, 2024
Merged
9 tasks
@rnbguy rnbguy added this to ibc-rs May 8, 2024
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs May 8, 2024
@rnbguy rnbguy moved this from 📥 To Do to 🏗️ In Progress in ibc-rs May 8, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnbguy rnbguy

Labels
A: bug Admin: something isn't working A: critical Admin: critical or Important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

imp(testkit): integration test for packet timeout informalsystems/ibc-rs
1 participant
@rnbguy