Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make events emitted in handlers compatible with ibc-go #11

Closed
5 tasks
plafer opened this issue Aug 8, 2022 · 1 comment
Closed
5 tasks

Make events emitted in handlers compatible with ibc-go #11

plafer opened this issue Aug 8, 2022 · 1 comment
Assignees
@plafer

Comments

@plafer
Copy link
Contributor

plafer commented Aug 8, 2022

Summary of Bug

We currently don't output the same events as ibc-go (e.g. due to the extensive use of default values).

Acceptance criteria

  • All our handlers output events under the same conditions as ibc-go
  • No default values are used

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer plafer self-assigned this Aug 8, 2022
@plafer plafer mentioned this issue Aug 8, 2022
Closed
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 28, 2022
@plafer
Copy link
Contributor Author

plafer commented Nov 14, 2022

Done in #145 and #146

@plafer plafer closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plafer